Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump itertools version to allow 0.12 #963

Closed
wants to merge 1 commit into from
Closed

Bump itertools version to allow 0.12 #963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion prost-build/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ cleanup-markdown = ["pulldown-cmark", "pulldown-cmark-to-cmark"]
[dependencies]
bytes = { version = "1", default-features = false }
heck = "0.4"
itertools = { version = ">=0.10, <0.12", default-features = false, features = ["use_alloc"] }
itertools = { version = ">=0.10, <0.13", default-features = false, features = ["use_alloc"] }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I think this syntax explains better the intent of the version bounds.

Suggested change
itertools = { version = ">=0.10, <0.13", default-features = false, features = ["use_alloc"] }
itertools = { version = ">=0.10, <=0.12", default-features = false, features = ["use_alloc"] }

Copy link

@MarijnS95 MarijnS95 Mar 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caspermeijn one thing that might be hiding is that this version range, whether it is written as <0.13 or <=0.12, allows 0.12.99999. Some folks find that confusing with the second format, though I also prefer to read the version that is included rather than the one that is excluded 👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the intention is to include/allow 0.12 series, so I prefer to write is the suggested way.

log = "0.4"
multimap = { version = "0.8", default-features = false }
petgraph = { version = "0.6", default-features = false }
Expand Down
2 changes: 1 addition & 1 deletion prost-derive/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ proc_macro = true

[dependencies]
anyhow = "1.0.1"
itertools = { version = ">=0.10, <0.12", default-features = false, features = ["use_alloc"] }
itertools = { version = ">=0.10, <0.13", default-features = false, features = ["use_alloc"] }
proc-macro2 = "1"
quote = "1"
syn = { version = "2", features = [ "extra-traits" ] }
Loading