Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple attributes support #522

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Fix multiple attributes support #522

merged 2 commits into from
Sep 15, 2021

Conversation

Guiguiprim
Copy link
Contributor

Improves PathMap:

LucioFranco
LucioFranco requested changes Sep 4, 2021
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great, I left a few inline comments/questions.

prost-build/src/code_generator.rs Outdated Show resolved Hide resolved
prost-build/src/code_generator.rs Outdated Show resolved Hide resolved
prost-build/src/code_generator.rs Outdated Show resolved Hide resolved
prost-build/src/path.rs Show resolved Hide resolved
prost-build/src/path.rs Outdated Show resolved Hide resolved
prost-build/src/path.rs Outdated Show resolved Hide resolved
prost-build/src/path.rs Outdated Show resolved Hide resolved
This was referenced Sep 4, 2021
Closed
Closed
LucioFranco
LucioFranco approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LucioFranco LucioFranco merged commit d45a37c into tokio-rs:master Sep 15, 2021
This was referenced Sep 15, 2021
Open
Closed
Closed
ajguerrer pushed a commit to ajguerrer/prost that referenced this pull request Sep 17, 2021
@Guiguiprim @LucioFranco @andrewg-spectra
Fix multiple attributes support (tokio-rs#522)
51ebdd7 
This address tokio-rs#490 tokio-rs#502 tokio-rs#507

Co-authored-by: Guilhem Vallat <guilhem@harfanglab.fr>
Co-authored-by: Lucio Franco <luciofranco14@gmail.com>
@Logarithmus
Copy link

@LucioFranco new release maybe? We can't use this fix until it ends up in a new release.

@graelo
Copy link

graelo commented Oct 5, 2021 •
edited
Loading

Yes, that would be awesome to have a new release with this fix.

@graelo
Copy link

graelo commented Oct 14, 2021

Thanks for 0.9!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Guiguiprim @Logarithmus @graelo @LucioFranco