prost_build::Config::file_descriptor_set_path #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for writing an encoded version of the appropriate FileDescriptorSet to a file named `file_descriptor_set.bin` in the output directory. This can be used with the `include_bytes` macro by consuming applications or libraries. The rationale for this pull request is to support the gRPC Server Reflection Protocol, which operates in terms of FileDescriptorProto, in Tonic. FileDescriptorProto instances are contained inside a FileDescriptorSet.
danburkert
force-pushed
the
file-descriptor-set-dcb
branch
from
ac04240 to
f90f2d1
Compare
This tweaks the file descriptor set option to take a path argument instead of a fixed path. This allows it to work with crates who invoke `prost-build` multiple times. It also saves `prost-build` from having to read and re-encode the file descriptor set, which could have subtle effects on it.
danburkert
force-pushed
the
file-descriptor-set-dcb
branch
from
f90f2d1 to
93a35cb
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is spiritually the same as #326 (and includes the commits from that branch), but changes the API/implementation to be a bit more flexible and simpler, respectively. The
file_descriptor_set_pathtakes a path argument which is passed directly toprotoc. The upside is that crates which callprost_buildmultiple times can have separate paths, andprostis no longer involved in parsing/re-serializing the file descriptor set, which could have subtle implications. The downside is that the API is a bit more cumbersome, but the addition of an example should offset this.