Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the check for existing protoc at build time (#283) #324

Merged
merged 4 commits into from
May 11, 2020
Merged

Remove the check for existing protoc at build time (#283) #324

merged 4 commits into from
May 11, 2020

Conversation

danburkert
Copy link
Collaborator

This to allow setting PROTOC=protoc, which in turn allows for using a protoc found in PATH.

This is a breaking change.

@danburkert danburkert mentioned this pull request May 11, 2020
Closed
@danburkert danburkert merged commit 2e04c72 into master May 11, 2020
@danburkert danburkert deleted the runtime-protoc branch May 11, 2020 01:57
@danburkert danburkert mentioned this pull request May 11, 2020
Closed
Tuetuopay pushed a commit to Tuetuopay/prost that referenced this pull request Jun 23, 2020
@danburkert
Remove the check for existing protoc at build time (tokio-rs#283) (to…
f14a097 
…kio-rs#324)

* Allow PROTOC env to be overriden at runtime

* fix tests

Co-authored-by: Gabriel de Russo e Carmo <gabrielrc@fb.com>
@illicitonion illicitonion mentioned this pull request Oct 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danburkert