Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(protobuf): Don't install unused test proto #1116

Merged
merged 1 commit into from
Aug 16, 2024
Merged

build(protobuf): Don't install unused test proto #1116

merged 1 commit into from
Aug 16, 2024

Commits on Aug 16, 2024

  1. build(protobuf): Don't install unused test proto 

    The build script of crate `protobuf` installs some proto-files for testing in the prefix dir. However the only user is the same build script. Therefore we can skip the install and use the files directly.

Use `absolute` path instead of `canonical` path, as `protoc` on Windows is not able to process `canonical` paths. This is sort of documented in https://doc.rust-lang.org/std/fs/fn.canonicalize.html
    @caspermeijn
    caspermeijn committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    6b9f58e View commit details
    Browse the repository at this point in the history