chore: Split prost-types lib.rs into separate modules. #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Shit, rebased anyway after the LGTM, sorry. Pressed the rebase button on Github, nothing else. |
No problem. My first reaction was: it needs a rebase. My second reaction was: well, GitHub will do that automatically. |
|
Hehe. It do be like that sometimes. Thanks 😊 |
gibbz00
added a commit
to gibbz00/prost
that referenced
this pull request
Mar 29, 2024
* prost-types: Place type implementations in modules. * prost-types: Extract modules to separate files. * prost-types: Move tests to the respective modules.
gibbz00
added a commit
to gibbz00/prost
that referenced
this pull request
Apr 6, 2024
* prost-types: Place type implementations in modules. * prost-types: Extract modules to separate files. * prost-types: Move tests to the respective modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf JSON mapping requires a lot of custom serializing for each protobuf type. Continuing to add that logic in a huge lib.rs file would quickly make these things harder to maintain and reason about.
Depends on #1006