Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protoc_from_env and protoc_include_from_env are not exposed in 0.12.5 #1062

Closed
TheLortex opened this issue May 16, 2024 · 0 comments · Fixed by #1063
Closed

protoc_from_env and protoc_include_from_env are not exposed in 0.12.5 #1062

TheLortex opened this issue May 16, 2024 · 0 comments · Fixed by #1063

Comments

@TheLortex
Copy link

TheLortex commented May 16, 2024 •
edited
Loading

Hi,

This commit 30b22d3 introduces a breakage because the pub functions protoc_from_env and protoc_include_from_env are moved in the config.rs file.

Because config.rs is privately imported, its pub functions are not available anymore from outside crates.
eopb added a commit to eopb/prost that referenced this issue May 16, 2024
@eopb
fix(prost-build): re-export protoc_from_env & `protoc_include_from_…
5c8f110 
…env`

fixes: tokio-rs#1062

I'm adding these because of a breaking change introduced in tokio-rs#1020

Since `0.12.5` this is causing build failures after `cargo update`.

```
   Compiling grpc-build v6.1.0
error[E0432]: unresolved imports `prost_build::protoc_from_env`, `prost_build::protoc_include_from_env`
 --> /Users/ethan.brierley/.cargo/registry/src/index.crates.io-6f17d22bba15001f/grpc-build-6.1.0/src/lib.rs:3:19
  |
3 | use prost_build::{protoc_from_env, protoc_include_from_env, Module};
  |                   ^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^^^^^ no `protoc_include_from_env` in the root
  |                   |
  |                   no `protoc_from_env` in the root
```
eopb added a commit to eopb/prost that referenced this issue May 16, 2024
@eopb
fix(prost-build): re-export protoc_from_env & `protoc_include_from_…
1e5e904 
…env`

fixes: tokio-rs#1062

I'm adding to fix a breaking change introduced in tokio-rs#1020
which moved these items.

Since `0.12.5` this is causing build failures after `cargo update`.

```
   Compiling grpc-build v6.1.0
error[E0432]: unresolved imports `prost_build::protoc_from_env`, `prost_build::protoc_include_from_env`
 --> /Users/ethan.brierley/.cargo/registry/src/index.crates.io-6f17d22bba15001f/grpc-build-6.1.0/src/lib.rs:3:19
  |
3 | use prost_build::{protoc_from_env, protoc_include_from_env, Module};
  |                   ^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^^^^^ no `protoc_include_from_env` in the root
  |                   |
  |                   no `protoc_from_env` in the root
```
@eopb eopb mentioned this issue May 16, 2024
Merged
eopb added a commit to eopb/prost that referenced this issue May 17, 2024
@eopb
fix(prost-build): re-export error_message_protoc_not_found, `protoc…
f4be7b7 
…_from_env` & `protoc_include_from_env`

fixes: tokio-rs#1062

I'm adding to fix a breaking change introduced in tokio-rs#1020
which moved these items.

Since `0.12.5` this is causing build failures after `cargo update`.

```
   Compiling grpc-build v6.1.0
error[E0432]: unresolved imports `prost_build::protoc_from_env`, `prost_build::protoc_include_from_env`
 --> /Users/ethan.brierley/.cargo/registry/src/index.crates.io-6f17d22bba15001f/grpc-build-6.1.0/src/lib.rs:3:19
  |
3 | use prost_build::{protoc_from_env, protoc_include_from_env, Module};
  |                   ^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^^^^^ no `protoc_include_from_env` in the root
  |                   |
  |                   no `protoc_from_env` in the root
```
github-merge-queue bot pushed a commit that referenced this issue May 17, 2024
@eopb
fix(prost-build): re-export error_message_protoc_not_found, `protoc…
4b11315 
…_from_env` & `protoc_include_from_env` (#1063)

fixes: #1062

I'm adding to fix a breaking change introduced in #1020
which moved these items.

Since `0.12.5` this is causing build failures after `cargo update`.

```
   Compiling grpc-build v6.1.0
error[E0432]: unresolved imports `prost_build::protoc_from_env`, `prost_build::protoc_include_from_env`
 --> /Users/ethan.brierley/.cargo/registry/src/index.crates.io-6f17d22bba15001f/grpc-build-6.1.0/src/lib.rs:3:19
  |
3 | use prost_build::{protoc_from_env, protoc_include_from_env, Module};
  |                   ^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^^^^^ no `protoc_include_from_env` in the root
  |                   |
  |                   no `protoc_from_env` in the root
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@TheLortex