Include relevant parts of ntapi v.0.3.7 within mio #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the relevant parts of ntapi v.0.3.7 in mio v.0.7.x in order to get rid of rejected code.
|
@Darksonn @carllerche what do you guys think about including this much code from another crate? Is this allowed licensing wise? I suppose it's just struct and function definition found in Windows, but I'm not a lawyer. |
|
Licensing-wise it is fine. The code in ntapi is available under the MIT license, and the code in mio is available under the MIT license. So including code from ntapi in mio is okay. |
Thomasdezeeuw
approved these changes
Aug 21, 2023
|
Alright, should be good to go now. |
Thomasdezeeuw
approved these changes
Aug 23, 2023
|
Thanks @FrankenApps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative / follow-up to #1707.
I add the relevant parts of
ntapiv.0.3.7 tomiov.0.7.x in order to get rid of rejected code.More specifically the code in question were these two lines (here and here) which triggered the
unaligned_referenceserror that is a hard error since Rust version 1.68.