Remove unused kernel diagnostic from io-uring-test #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This diagnostic is both unused and unreliable because uname may return kernel versions that semver cannot parse, such as '6.8.9-300.fc40.x86_64'.
|
Given that we're not using it, it's good to remove it. We can reintroduce it if necessary. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there! I am a happy user of this library with a small contribution to make. I want to remove a field from the
Teststruct.The
io-uring-testcrate is broken on any system for whichunamereturns a kernel version that doesn't conform to semver. This includes Fedora Linux, whereunamemight return areleasesuch as6.8.9-300.fc40.x86_64. I was going to file an issue but then I noticed this code isn't actually used anywhere. By removing this field fromTestI'd fix the issue for myself and others, while also removing the dependency on thesemvercrate.