fix(api): fix accidental exhaustive matching on metadata::Kind
#271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `tracing_core::metadata::Kind` type was not intended to be matched exhaustively, so that its internal representation could be changed without causing a breaking change. However, some fairly recent compiler changes broke this, and made the type exhaustively matched. This resulted in `tracing-core` 0.1.22 breaking `console-api`. This PR fixes the breakage by changing `console-api` to avoid exhaustively matching on `Kind`s. Fixes #270
|
Once this is published, I think we may need to yank all previous versions of |
|
This looks good to me, but is there any reason not to just delete the whole edit: answered in the other issue |
yeah, deleting the |
seanmonstar
approved these changes
Feb 4, 2022
hawkw
added a commit
that referenced
this pull request
Feb 4, 2022
hawkw
added a commit
that referenced
this pull request
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tracing_core::metadata::Kindtype was not intended to be matchedexhaustively, so that its internal representation could be changed
without causing a breaking change. However, some fairly recent compiler
changes broke this, and made the type exhaustively matched. This
resulted in
tracing-core0.1.22 breakingconsole-api.This PR fixes the breakage by changing
console-apito avoidexhaustively matching on
Kinds.Fixes #270