Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: pin nightly version for cargo public-api-crates #2779

Merged
merged 4 commits into from
Jun 9, 2024

Conversation

mladedav
Copy link
Collaborator

@mladedav mladedav commented Jun 9, 2024

Motivation

The CI is failing due to changes in nightly which cargo-public-api-crates is not ready for.

Solution

Pin the nightly version to a prior version that is known to work until the tool is updated to handle current nightly.

Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out! Looks like the relevant jobs are all passing now.

@jplatte jplatte merged commit 806bc26 into tokio-rs:main Jun 9, 2024
18 checks passed
@mladedav
Copy link
Collaborator Author

mladedav commented Jun 9, 2024

Finally 🎊

I didn't look too closely into what the tool actually does, but hopefully when the 2024 edition lands, we can switch to the private/public dependencies feature.

@mladedav mladedav deleted the dm/actually-fix-ci branch June 9, 2024 21:34
@jplatte
Copy link
Member

jplatte commented Jun 9, 2024

Well, likely not unfortunately: rust-lang/rust#44663 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants