Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update router::route multiple methods docs #2051

Merged
merged 3 commits into from
Jun 22, 2023

Conversation

mohad12211
Copy link
Contributor

@mohad12211 mohad12211 commented Jun 20, 2023

Motivation

In the early days you had to add handlers at the same time if they are for the same route with different methods,
but that hasn't been the case for a while.
Now you can do both but the docs are outdated.

Solution

Change must to can, and add a note that the one-by-one way is also possible.

Relevant discussion

Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidpdrsn davidpdrsn enabled auto-merge (squash) June 22, 2023 21:26
@davidpdrsn davidpdrsn merged commit 652d65a into tokio-rs:main Jun 22, 2023
@mohad12211 mohad12211 deleted the router_route_docs branch June 22, 2023 21:51
davidpdrsn added a commit that referenced this pull request Jul 16, 2023
Co-authored-by: David Pedersen <david.pdrsn@gmail.com>
@davidpdrsn davidpdrsn mentioned this pull request Jul 16, 2023
davidpdrsn added a commit that referenced this pull request Jul 17, 2023
Co-authored-by: David Pedersen <david.pdrsn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants