Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Clone for CookieJar, PrivateCookieJar and SignedCookieJar #1808

Merged
merged 3 commits into from
Mar 3, 2023
Merged

Implement Clone for CookieJar, PrivateCookieJar and SignedCookieJar #1808

merged 3 commits into from
Mar 3, 2023

Conversation

danhandrea
Copy link
Contributor

Motivation

Derive Clone missing from CookieJar.

Solution

Add Clone to CookieJar

@davidpdrsn davidpdrsn added C-enhancement Category: A PR with an enhancement A-axum-extra labels Mar 3, 2023
davidpdrsn
davidpdrsn reviewed Mar 3, 2023
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should do the same for SignedCookieJar and PrivateCookieJar.

Also, do you wanna add a note to change log?

@danhandrea
Copy link
Contributor Author

Implemented for SignedCookieJar and PrivateCookieJar.
Also updated the change log.

@davidpdrsn davidpdrsn changed the title derive Clone for CookieJar Implement Clone for CookieJar, PrivateCookieJar and SignedCookieJar Mar 3, 2023
davidpdrsn
davidpdrsn approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

jplatte
jplatte approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@davidpdrsn davidpdrsn enabled auto-merge (squash) March 3, 2023 11:09
@davidpdrsn davidpdrsn merged commit e167cfc into tokio-rs:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

@davidpdrsn davidpdrsn davidpdrsn approved these changes

Assignees
No one assigned
Labels
A-axum-extra C-enhancement Category: A PR with an enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danhandrea @davidpdrsn @jplatte