Remove remnants of spa feature #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpdrsn
approved these changes
Mar 2, 2023
|
Is it better to remove the comment and the example code and leave the feature for the next breaking release? |
|
Nah I don't think so. The whole point of axum-extra is that we can make breaking changes. We just did one recently but doing another one isn't the end of the world. Can probably do one this week or next. |
davidpdrsn
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I saw that
SpaRouterwas removed in #1784, but thespafeature flag was still referenced in a few places, including doc comments.Solution
I cleaned up the remnants of the
spafeature flag that I could find.