Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypedPath::with_query_params #1744

Merged
merged 7 commits into from
Feb 11, 2023
Merged

Add TypedPath::with_query_params #1744

merged 7 commits into from
Feb 11, 2023

Conversation

davidpdrsn
Copy link
Member

Fixes #1740

@davidpdrsn davidpdrsn requested a review from jplatte February 11, 2023 15:14
erlandsona
erlandsona approved these changes Feb 11, 2023
View reviewed changes
Copy link

@erlandsona erlandsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I was requesting 🙌 🙇 lookin' forward to the merge and tinkerin' with it myself! Much better than the helper functions I've been cobbling together!

jplatte
jplatte reviewed Feb 11, 2023
View reviewed changes
axum-extra/src/routing/typed.rs Outdated Show resolved Hide resolved
axum-extra/src/routing/typed.rs Outdated Show resolved Hide resolved
@davidpdrsn davidpdrsn requested a review from jplatte February 11, 2023 21:58
@davidpdrsn davidpdrsn enabled auto-merge (squash) February 11, 2023 22:00
jplatte
jplatte requested changes Feb 11, 2023
View reviewed changes
axum-extra/Cargo.toml Outdated Show resolved Hide resolved
@davidpdrsn @jplatte
Update axum-extra/Cargo.toml
7c6e406 
Co-authored-by: Jonas Platte <jplatte+git@posteo.de>
@davidpdrsn davidpdrsn requested a review from jplatte February 11, 2023 22:01
@davidpdrsn davidpdrsn merged commit b4204e2 into main Feb 11, 2023
@davidpdrsn davidpdrsn deleted the typed-path-query-params branch February 11, 2023 22:10
@erlandsona
Copy link

Hot dog! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlandsona erlandsona erlandsona approved these changes

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
A-axum-extra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Query Parameter functionality to TypedPath
3 participants
@davidpdrsn @erlandsona @jplatte