Add option_layer
#1696
Merged
Add option_layer
#1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tower already has `option_layer` for conditionally applying a `Layer` but since it uses `tower::util::Either` it always changes the error type to `BoxError`. That requires using `HandleErrorLayer` which is inconvenient for axum users. That has been changed in tower (tower-rs/tower#637) but still has some issues (tower-rs/tower#665). Its also a breaking change so hasn't been released yet. In the meantime I figure we can provide our own thing in axum-extra, since we already have an `Either` type there.
davidpdrsn
force-pushed
the
option-layer
branch
from
8a397ce to
933cb5f
Compare
jplatte
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tower already has
option_layerfor conditionally applying aLayerbut since it usestower::util::Eitherit always changes the error type toBoxError. That requires usingHandleErrorLayerwhich is inconvenient for axum users.That has been changed in tower
(tower-rs/tower#637) but still has some issues (tower-rs/tower#665). Its also a breaking change so hasn't been released yet.
In the meantime I figure we can provide our own thing in axum-extra, since we already have an
Eithertype there.