Change casing of ProtoBuf to Protobuf #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The casing "Protobuf" is canonical. Note the lowercase "b". The [protocolbuffers/protobuf](https://github.com/protocolbuffers/protobuf) repo uses this casing exclusively. Examples: - [Protobuf.java](https://github.com/protocolbuffers/protobuf/blob/7c308c7d45996e9d890623d80636319b292b84bc/java/core/src/main/java/com/google/protobuf/Protobuf.java#L45) - [protobuf.rb](https://github.com/protocolbuffers/protobuf/blob/7c308c7d45996e9d890623d80636319b292b84bc/ruby/lib/google/protobuf.rb#L37) This PR replaces all references of "ProtoBuf" to be "Protobuf". - 36 substitions in *axum-extra/src/protobuf.rs* - 1 substition in *axum-extra/src/lib.rs* - one untouched casing of "Protobuf" in *ECOSYSTEM.md*
|
Looks good! Though this is a breaking change so has to wait until we ship the next major release of axum-extra. That'll most likely be with axum 0.7.0. Wanna update the changelog as well? |
davidpdrsn
added
breaking change
davidpdrsn
reviewed
Nov 29, 2022
Co-authored-by: David Pedersen <david.pdrsn@gmail.com>
davidpdrsn
approved these changes
Feb 17, 2023
|
Ah wait... It only touched axum-extra so doesn't need to go out with axum 0.7. Guess I'll reopen this PR 😅 |
davidpdrsn
added a commit
that referenced
this pull request
Feb 17, 2023
Co-authored-by: David Pedersen <david.pdrsn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The casing "Protobuf" is canonical. Note the lowercase "b". The protocolbuffers/protobuf repo uses this casing exclusively.
Examples:
This PR replaces all references of "ProtoBuf" to be "Protobuf".