Add JsonLines extractor and response
#1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Jun 16, 2022
|
Just a small comment about the naming. |
|
@FSMaxB Good point! I had only heard of "newline delimited json" but seeing as json lines appears to be thing I like that name more. |
Co-authored-by: Jonas Platte <jplatte+git@posteo.de>
davidpdrsn
changed the title
NdJson extractor and responseJsonLines extractor and response
jplatte
approved these changes
Jun 20, 2022
| @@ -67,6 +68,9 @@ pub mod extract; | |||
| pub mod response; | |||
| pub mod routing; | |||
|
|
|||
| #[cfg(feature = "json-lines")] | |||
| pub mod json_lines; | |||
There was a problem hiding this comment.
In axum, only the Json type is exported at the root, not the json module. Does this deviate from that because there's more types to expose?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
JsonLineswhich is a newline delimited JSON extractor and response. Its partly inspired byactix_web_lab::respond::NdJson.I had a use case for this today and figured it makes sense to upstream.