Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile times are slower on 1.56 #399

Closed
davidpdrsn opened this issue Oct 23, 2021 · 2 comments · Fixed by #404
Closed

Compile times are slower on 1.56 #399

davidpdrsn opened this issue Oct 23, 2021 · 2 comments · Fixed by #404
Labels
C-bug Category: This is a bug. P-high High priority

Comments

@davidpdrsn
Copy link
Member

Rust 1.56 has had a regression in compile times that impacts axum. Some users have reported significantly worse compile times on 1.56.

I think the solution will be #393 but have to do some more testing before we can ship a release.

I will also open an issue for rustc (unless someone already has)
@davidpdrsn davidpdrsn added P-high High priority C-bug Category: This is a bug. labels Oct 23, 2021
@davidpdrsn davidpdrsn pinned this issue Oct 23, 2021
@paolobarbolini
Copy link
Contributor

I already reported it rust-lang/rust#89601 and was basically marked as duplicate, as there already is rust-lang/rust#89195

@davidpdrsn davidpdrsn mentioned this issue Oct 23, 2021
Closed
@malobre malobre mentioned this issue Oct 23, 2021
Closed
@davidpdrsn davidpdrsn added this to the 0.4 milestone Oct 24, 2021
@davidpdrsn davidpdrsn mentioned this issue Oct 24, 2021
Merged
davidpdrsn added a commit that referenced this issue Oct 24, 2021
@davidpdrsn
Fix compile time regression by boxing routes internally (#404)
0ee7379 
This is a reimplementation of #401 but with the new matchit based router.

Fixes #399
@davidpdrsn
Copy link
Member Author

This bug is fixed in #404 and will be shipped in 0.3

@davidpdrsn davidpdrsn unpinned this issue Nov 3, 2021
@techno-tanoC techno-tanoC mentioned this issue Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. P-high High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compile time regression by boxing routes internally tokio-rs/axum
2 participants
@davidpdrsn @paolobarbolini