Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use impl Into<Cookie> #2347

Closed
davidpdrsn opened this issue Nov 24, 2023 · 1 comment · Fixed by #2348
Closed

Use impl Into<Cookie> #2347

davidpdrsn opened this issue Nov 24, 2023 · 1 comment · Fixed by #2348
Labels
A-axum-extra C-feature-request Category: A feature request, i.e: not implemented / a PR. E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue.
Milestone
0.7

Comments

@davidpdrsn
Copy link
Member

We updated to the latest version of cookie in #2343 and they've changed a bunch of methods to use impl Into<Cookie>. Their changelog has the details.

We should make similar changes in axum-extra. At least CookieJar::add but probably also others.
@davidpdrsn davidpdrsn added C-feature-request Category: A feature request, i.e: not implemented / a PR. E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. A-axum-extra labels Nov 24, 2023
@davidpdrsn davidpdrsn added this to the 0.7 milestone Nov 24, 2023
@davidpdrsn davidpdrsn mentioned this issue Nov 24, 2023
Merged
@jplatte
Copy link
Member

jplatte commented Nov 24, 2023

Related, we should mention the upgrade in the changelog. I only thought about that after pressing merge on #2343.

mseele added a commit to mseele/axum that referenced this issue Nov 24, 2023
@mseele
fix: use impl Into<Cookie>
7254210 
closes tokio-rs#2347
@mseele mseele mentioned this issue Nov 24, 2023
Merged
mseele added a commit to mseele/axum that referenced this issue Nov 24, 2023
@mseele
fix: use impl Into<Cookie>
032c8db 
closes tokio-rs#2347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-axum-extra C-feature-request Category: A feature request, i.e: not implemented / a PR. E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue.
Projects
None yet
Milestone
0.7
Development

Successfully merging a pull request may close this issue.

fix: use impl Into<Cookie> mseele/axum
2 participants
@davidpdrsn @jplatte