feat: coverage for adotokenstorage #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Commit SHA:dbf86580f456eba2bb318da74383c0aabe4942f6 Test coverage results 🧪
|
six7
requested changes
Jun 17, 2022
| @@ -280,13 +285,13 @@ export class ADOTokenStorage extends GitTokenStorage { | |||
| return [ | |||
| { | |||
| type: 'themes', | |||
| path: `${this.path}/$themes.json`, | |||
| path: this.path, | |||
There was a problem hiding this comment.
So does this store $themes in the same file as the sets then? How did this even work before?
There was a problem hiding this comment.
It does - it has to because of how the multifile was set-up from the beginning. It is based on the filename. It was not possible to change the file structure anymore since it had alreayd been set in a flat file structure.
Co-authored-by: Jan Six <six.jan@gmail.com>
|
Commit SHA:edc2a0b1db0809ceba79a4db1341dfabdcbdfaca Test coverage results 🧪
|
six7
approved these changes
Jun 20, 2022
MightyDevKnight
pushed a commit
that referenced
this pull request
Jun 20, 2022
* feat: Added coverage for ADO Token Storage * chore: Typo Co-authored-by: Jan Six <six.jan@gmail.com> Co-authored-by: Jan Six <six.jan@gmail.com>
MightyDevKnight
pushed a commit
that referenced
this pull request
Jun 30, 2022
* feat: Added coverage for ADO Token Storage * chore: Typo Co-authored-by: Jan Six <six.jan@gmail.com> Co-authored-by: Jan Six <six.jan@gmail.com>
MightyDevKnight
pushed a commit
that referenced
this pull request
Jun 30, 2022
* feat: Added coverage for ADO Token Storage * chore: Typo Co-authored-by: Jan Six <six.jan@gmail.com> Co-authored-by: Jan Six <six.jan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.