Allow spaces in token names #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/six7/figma-tokens/9pU5s4K9TdzGXe2w6qeiq1ERPXDJ |
six7
added a commit
that referenced
this pull request
Nov 28, 2021
* Box shadows (#306) * add support for multiple box shadows * fix color evaluation * remove logs * remove logs * revert css removal * remove line * remove code not part of boxShadows * fix alias calculation (#307) * fix lightOrDark visualization by converting hsla before calculating (#311) * fix lightOrDark visualization by converting hsla before calculating * fix tests * fixes #295 (#304) * fixes #295 * add spec * add textCase and textDecoration (#303) * add textCase and textDecoration * add tests * add more tests * add transforms to allow users to type lowercase * add tests and transforms * introduce small_caps and small_caps_forced * remove log * add type props * add working pull/update with json * add catch for lightOrDark * fix removal of documentation tokens * move extraProperties to upper layer so isActive works * bump release * add edit boxshadow ui * add pretty import dialog * fix shadow input not updating, styling * add test for filterMatchingStyle * add tests for setEffectValuesOnTarget * add tests for setValuesOnNode * update tests for updateStyles * add test for tokenHelper array * add cypress tests * add cypress spec * fixes #331 * remove log * fix apply shadows * GitHub sync enterprise support & optimizations (#329) * add working gh enterprise sync * Add baseUrl to permission check * remove console log * fix unexpected pull * add checks for future optimizations * add tests * add permission check to restoring * fix git sync permissions * fix duplicate keys * show error when bad credentials * fix cancel import * Allow spaces in token names (#339) * allow spaces in token names * remove unneccessary escape fixes #323 * fix spec * Update tokens.spec.js * Update tokens.spec.js * fix dnd * bump release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes aliasRegex to also allow spaces in token names. Might need more refinement to filter out cases that contain a space at the beginning but for now that's enough.
Resolves #323