chore: fix linting

[jorenbroekema]

Why does this PR exist?

#3142 prepping, in order to add a new lint plugin we need to ensure our linting setup works at least.

What does this pull request do?

Fix some config things, fix some lint errors in the code, adjust config a bit to fit our codebase so I don't have to change too much source code in order to get it passing.

Testing this change

run yarn lint locally in this branch

[github-actions]

Commit SHA:4b317966278f79b4e17c121e9af4cc3a63c80ef7

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: fix-linting 

Status	File	% Stmts	% Branch	% Funcs	% Lines
🟢	total	67 (0.02)	57.83 (-0.03)	63.88 (0.04)	67.36 (0.02)
🟢	packages/tokens-studio-for-figma/src/app/components/ChangeStateListingHeading.tsx	25 (5)	0 (0)	0 (0)	25 (5)
🟢	packages/tokens-studio-for-figma/src/app/components/ColorTokenForm.tsx	1.29 (0.09)	0 (0)	0 (0)	1.33 (0.1)
🔴	packages/tokens-studio-for-figma/src/app/components/MultiSelectDropdown.tsx	53.84 (-3.3)	0 (0)	60 (0)	54.54 (-3.79)
🔴	packages/tokens-studio-for-figma/src/app/components/Tokens.tsx	72.85 (-0.38)	27.02 (0)	57.89 (0)	71.64 (-0.41)
🔴	packages/tokens-studio-for-figma/src/app/components/AddLicenseKey/AddLicenseKey.tsx	89.18 (-0.29)	73.33 (0)	77.77 (0)	91.66 (-0.23)
🔴	packages/tokens-studio-for-figma/src/app/components/Modal/Modal.tsx	70 (-5)	75 (-6.25)	66.66 (0)	70 (-5)
🔴	packages/tokens-studio-for-figma/src/app/components/modals/CreateStorageItemModal.tsx	63.63 (-1.58)	25 (0)	50 (0)	63.63 (-1.58)
🔴	packages/tokens-studio-for-figma/src/app/components/modals/DuplicateTokenGroupModal.tsx	53.57 (-1.98)	31.57 (-3.72)	20 (0)	53.57 (-1.98)
🟢	packages/tokens-studio-for-figma/src/utils/alias/checkIfAlias.tsx	63.15 (0)	61.11 (0)	33.33 (0)	70.58 (3.92)
🟢	packages/tokens-studio-for-figma/src/utils/alias/getAliasValue.ts	89.39 (0)	81.81 (0)	100 (0)	89.23 (0.17)

[github-actions]

Commit SHA:4b317966278f79b4e17c121e9af4cc3a63c80ef7
Current PR reduces the test coverage percentage by 1 for some tests

[jorenbroekema]

FYI the coverage has declined because I removed unused code, so less lines of covered code = lower percentage of code covered.
Dunno if we can ignore it somehow, do we set thresholds somewhere?

[changeset-bot]

⚠️ No Changeset found

Latest commit: e897fc7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁