Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply linear gradient incase variable reference not resolved #3159

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

macintoshhelper
Copy link
Contributor

@macintoshhelper macintoshhelper commented Sep 30, 2024

Why does this PR exist?

Fixes #3150

What does this pull request do?

Testing this change

Steps to reproduce the behavior:

  1. Create a gradient, for example: linear-gradient(45deg, #ff00ff 0%, #ff0000 100%)

  2. Reference this gradient in another token (in the same or other set)

  3. Export these as Styles in Figma

Additional Notes (if any)

Before

image

After

image

Copy link

changeset-bot bot commented Sep 30, 2024

🦋 Changeset detected

Latest commit: 3190587

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 30, 2024

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

@macintoshhelper macintoshhelper marked this pull request as ready for review September 30, 2024 19:13
Copy link
Contributor

github-actions bot commented Sep 30, 2024

Commit SHA:c33a2720f958a033ea7cf650269a2c3bf1d1c582

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: fix/3150-gradient-style-nested-reference 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 67.91 (0.01) 58.47 (-0.04) 64.67 (0.02) 68.29 (0)
🟢 packages/tokens-studio-for-figma/src/plugin/setColorValuesOnTarget.ts 92.18 (0.12) 88.75 (1.52) 100 (0) 93.22 (-1.32)

Copy link
Contributor

github-actions bot commented Sep 30, 2024

Commit SHA:c33a2720f958a033ea7cf650269a2c3bf1d1c582
Current PR reduces the test coverage percentage by 1 for some tests

Copy link
Contributor

@akshay-gupta7 akshay-gupta7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, working as expected 🎉
can you add the changeset as well!

@macintoshhelper macintoshhelper merged commit 7be0b29 into main Oct 3, 2024
10 of 11 checks passed
@macintoshhelper macintoshhelper deleted the fix/3150-gradient-style-nested-reference branch October 3, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Referencing gradients not working properly with Styles
2 participants