Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1224 plugin seems to reset window size when using deep inspect #1225

Merged

Conversation

swordEdge
Copy link
Contributor

@swordEdge swordEdge commented Aug 25, 2022

Fixed two issue.
#1223
#1224

The plugin seems to reset the window size when the user has

  1. Changed window size
  2. Then restarted the plugin
  3. Then - without changing window size - changing Deep inspect
    Notice how the plugin then resets the window size.

We seem to have caused a regression with Deep inspect:

To reproduce:

  1. Activate deep inspect
  2. Restart the plugin
  3. Select a layer
  4. Go to Inspect
  5. Notice how even though it says Deep inspect is on, it only shows values of that current layer, not of children.
  6. Turn Deep inspect off and on again
    Notice that it now works

After fixing: Plugin keeps the window size and all children tokens are displayed after restarting the plugin.

@vercel
Copy link

vercel bot commented Aug 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
figma-tokens ✅ Ready (Inspect) Visit Preview Aug 25, 2022 at 9:37AM (UTC)
ft-storybook ✅ Ready (Inspect) Visit Preview Aug 25, 2022 at 9:37AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022

Commit SHA:d86b706358b32bdf7688c138ac69277fed6e2c47

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: 1224-plugin-seems-to-reset-window-size-when-using-deep-inspect 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 67.32 (0.02) 58.52 (0) 63.93 (0.02) 67.49 (0.02)
🟢 src/app/store/models/settings.tsx 41.38 (2.09) 0 (0) 34.78 (2.96) 41.38 (2.09)

Copy link
Collaborator

@six7 six7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! @LiamMartens maybe you can re-review this afterwards, I think some of the startup logic changes were causing this regression.

@six7 six7 merged commit 284943f into main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants