Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1099-improve-the-list-of-available-tokens-in-a-dropdown #1191

Merged
merged 5 commits into from
Aug 22, 2022

Conversation

swordEdge
Copy link
Contributor

@swordEdge swordEdge commented Aug 19, 2022

Currently when you are replacing a token via Inspect Mode, you get a list of all the available tokens. This list is only not sorted in a proper way and seems to sort on create date.
In the past:
image

After fixing:
image

@vercel
Copy link

vercel bot commented Aug 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
figma-tokens ✅ Ready (Inspect) Visit Preview Aug 22, 2022 at 5:27AM (UTC)
ft-storybook ✅ Ready (Inspect) Visit Preview Aug 22, 2022 at 5:27AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2022

Commit SHA:d6dc7bd8c67efc6d50be8fc8b9ee2acc7010c2c1

Test coverage results 🧪

Code coverage diff between base branch:next and head branch: 1099-improve-the-list-of-available-tokens-in-a-dropdown 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 67.7 (0.4) 59.38 (0.84) 64.6 (0.69) 67.88 (0.41)
🟢 src/app/components/DownshiftInput/DownshiftInput.tsx 71.43 (54.76) 64.71 (64.71) 63.16 (63.16) 70.83 (53.81)
🟢 src/app/components/DownshiftInput/StyledDownshiftInput.tsx 100 (66.67) 66.67 (66.67) 100 (100) 100 (66.67)

@github-actions
Copy link
Contributor

Commit SHA:66a5bde849ccf06a579110ab9f1fda90c5ca347d
Current PR reduces the test coverage percentage by 1 for some tests

@swordEdge swordEdge changed the title sort filter tokens 1099-improve-the-list-of-available-tokens-in-a-dropdown Aug 19, 2022
@six7 six7 merged commit 31e3c60 into next Aug 22, 2022
@SorsOps SorsOps deleted the 1099-improve-the-list-of-available-tokens-in-a-dropdown branch July 6, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the list of available tokens in a dropdown
4 participants