add expandComposition

[swordEdge]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
figma-tokens	✅ Ready (Inspect)	Visit Preview	Aug 9, 2022 at 0:56AM (UTC)
ft-storybook	✅ Ready (Inspect)	Visit Preview	Aug 9, 2022 at 0:56AM (UTC)

[github-actions]

Commit SHA:16adee487c073993fb207916c1388017ead5dc36

Test coverage results 🧪

Code coverage diff between base branch:next and head branch: 1000-add-support-for-expandcompositiontokens-to-token-transformer 

Status	File	% Stmts	% Branch	% Funcs	% Lines
🟢	total	64.03 (0.05)	55.74 (0.26)	59.39 (0)	64.23 (0.04)
🟢	src/utils/convertTokens.tsx	80.56 (0.56)	73.91 (9)	80 (0)	80.56 (0.56)
🟢	src/utils/convertTokensToGroupedObject.ts	95 (10)	81.82 (6.82)	100 (0)	95 (10)
🟢	src/utils/is/isSingleCompositionToken.ts	100 (33.33)	100 (50)	100 (0)	100 (0)

[github-actions]

Commit SHA:effc3dd18b6f8983f2a888cd22169021c3fde49d
Current PR reduces the test coverage percentage by 1 for some tests

[six7]

Could you also add a few composition tokens in the https://github.com/six7/figma-tokens/tree/main/token-transformer/tokens files and make sure that we test that from a token-transformer level?

The "tests" there are basically running token-transformer with a few inputs that should then produce certain outputs: https://github.com/six7/figma-tokens/blob/main/token-transformer/package.json

Other than that this looks great!

[six7]

Can you add a test for this in token-transformer/transform.test.js? You'll need to add a output/composition.json so the test know what is the expected result, you can look at the other tests to see how that was done.

Also, package.json needs a change in the test script (line 18):
Change "test": "npm run build-typography-test && npm run build-light-test && npm run build-dark-test && npm run build-folder-test && npm run build-resolve-false-test && jest"

to "test": "npm run build-typography-test && npm run build-light-test && npm run build-dark-test && npm run build-folder-test && npm run build-resolve-false-test && npm run build-composition-test && jest"

[six7]

Suggested change

	"build-composition-test": "node index.js tokens.json temp/composition.json base/options,base/sizing,core/composition base/options,base/sizing",
	"build-composition-test": "node index.js tokens.json temp/composition.json base/options,base/sizing,core/composition base/options,base/sizing --expandComposition=true",

[six7]

this needs to be enabled to be run