Fix types for expanded (typography) tokens (#1423)

Fixes #1417 The ideal fix IMO would be to make all typography types singular. That is a more elaborate (and breaking) change though. So I thought this could already be a quick fix so it's at least consistent :) Co-authored-by: Jan Six <six.jan@gmail.com>
tokens-studio · Nov 12, 2022 · b0e4e69 · b0e4e69
1 parent b587c09
commit b0e4e69
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 14 deletions.
diff --git a/src/app/components/ExportProvider/SingleFileExport.test.tsx b/src/app/components/ExportProvider/SingleFileExport.test.tsx
@@ -171,11 +171,11 @@ describe('SingleFileExport', () => {
           headline: {
             fontFamily: {
               value: 'Inter',
-              type: 'fontFamily',
+              type: 'fontFamilies',
             },
             fontWeight: {
               value: 'Bold',
-              type: 'fontWeight',
+              type: 'fontWeights',
             },
           },
           alias: {

diff --git a/src/utils/convertToDefaultProperty.ts b/src/utils/convertToDefaultProperty.ts
@@ -31,6 +31,18 @@ export function convertToDefaultProperty(property: string): string {
     case Properties.borderWidthBottom:
       type = Properties.borderWidth;
       break;
+    case 'fontFamily':
+      type = Properties.fontFamilies;
+      break;
+    case 'fontSize':
+      type = Properties.fontSizes;
+      break;
+    case 'fontWeight':
+      type = Properties.fontWeights;
+      break;
+    case 'lineHeights':
+      type = Properties.lineHeights;
+      break;
     default:
       type = property;
       break;

diff --git a/src/utils/formatTokens.test.ts b/src/utils/formatTokens.test.ts
@@ -116,43 +116,43 @@ describe('formatTokens', () => {
                 h1: {
                   fontFamily: {
                     value: 'Inter',
-                    type: 'fontFamily',
+                    type: 'fontFamilies',
                   },
                   fontWeight: {
                     value: 'Bold',
-                    type: 'fontWeight',
+                    type: 'fontWeights',
                   },
                   fontSize: {
                     value: 36,
-                    type: 'fontSize',
+                    type: 'fontSizes',
                   },
                 },
                 h2: {
                   fontFamily: {
                     value: 'Inter',
-                    type: 'fontFamily',
+                    type: 'fontFamilies',
                   },
                   fontWeight: {
                     value: 'Regular',
-                    type: 'fontWeight',
+                    type: 'fontWeights',
                   },
                   fontSize: {
                     value: 24,
-                    type: 'fontSize',
+                    type: 'fontSizes',
                   },
                 },
                 alias: {
                   fontFamily: {
                     value: 'Inter',
-                    type: 'fontFamily',
+                    type: 'fontFamilies',
                   },
                   fontWeight: {
                     value: 'Bold',
-                    type: 'fontWeight',
+                    type: 'fontWeights',
                   },
                   fontSize: {
                     value: 36,
-                    type: 'fontSize',
+                    type: 'fontSizes',
                   },
                 },
                 non_resolved: {

diff --git a/token-transformer/output/composition.json b/token-transformer/output/composition.json
@@ -21,15 +21,15 @@
     "header": {
       "fontFamily": {
         "value": "Roboto",
-        "type": "fontFamily"
+        "type": "fontFamilies"
       },
       "fontSize": {
         "value": 96,
-        "type": "fontSize"
+        "type": "fontSizes"
       },
       "fontWeight": {
         "value": "Bold",
-        "type": "fontWeight"
+        "type": "fontWeights"
       }
     },
     "body": {