[TR3FIR-141] Update embassy to latest #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrf,rp,stm32: remove mod sealed.
This avoids cfg's, because it works both for timers that have a a dedicated CC interrupt line, and timers where all interrupts go to a single interrupt line.
stm32: fix timer api leaking
…up_and_pull-down Add parameter for enabling pull-up and pull-down in RP PWM input mode
mirrors change made in embassy-rs#2672.
stm32/qspi: autodeduce transfer len from buffer len.
stm32: adc: v3: [h5] set OR.OP0 to 1 when ADCx_INP0 is selected, per RM
Fix 'clocok' typo in RCC docs
Add VBUS detection blackpill comment
Co-authored-by: becothas <41289937+becothas@users.noreply.github.com>
[embassy-stm32] added comments explaining multiprio interrupts
embassy-sync: Add len, is_empty and is_full functions to Channel.
…ll_ functions This is a breaking change for users of the poll_ functions. (Some might not notice if they already pass in an IpEndpoint into poll_send_to, or discard that item in poll_recv_from).
Fix the comment about the default value: this defaults to 64 rather than 8 bytes. It seems like the max packet size for endpoint 0 should normally be selected automatically, rather than being part of the config. At best it seems like this setting should just be a hint that gets used if when the bus is operating at full speed. The contents of the device descriptor should ideally be updated with the correct max packet size after bus enumeration completes. In practice always using 64 is probably fine if low speed environments never need to be supported. (Super speed requires a max packet size of 512 bytes, which I didn't list in the comments here.)
USB: fix comments about the config.max_packet_size_0 field
This makes delay compatible with https://lib.rs/crates/rtic-monotonics.
…-unused-deps Removes some unused dependencies in embedded-net.
embassy_sync::Mutex: Implement traits to match std
impl ReadReady for tcp call can_recv() insted of may_recv()
Fix soundness issue introduced in a previous soundness fix embassy-rs#2602 . PeripheralRef must not implement DerefMut itself, but the blanket impl must still require DerefMut. Otherwise you can create two instances of a driver on the same uart by using `&my_uart`.
…deref Fix PeripheralRef soundness issue allowing &T.
Current name clashes with "regular" stm32h7 thus generating cargo warning.
stm32: examples: Use unique crate name for stm32h7rs examples
rp: Add raw interrupt handler example
Merging after Taylor's merge.
We did another upstream sync after the original. Merge that so we get those new pieces too.
Now that I've gotten it all working, go back to using artifactory instead of paths.
mattcaron-token
requested review from
DavidZemon,
TaylorCarpenter,
lukasz-zajac,
BednarzAleksander,
a user and
grochowski-withintent
TaylorCarpenter
suggested changes
May 9, 2024
This was something that Taylor fixed in 20faa0a and I had noticed when resolving the conflict, but I accepted the wrong side.
TaylorCarpenter
approved these changes
May 9, 2024
|
I'm not merging this yet because it's not being built. I've asked @DavidZemon to have a look, since he's the CI guy. |
David says it's only building I'm fine with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 3 merges here which likely don't need to be fully reviewed:
maininto this branch (at the time, it was namedpull_upstream2). This is just upstream commits, but I do resolve some conflicts. The conflict resolution bears review.token-maininto this branch. This is commits from Taylor's PR which have already been reviewed.maininto this branch. This is also just upstream commits.There are also 3 commits which are normal commits.
Everything that should be reviewed is tagged with TR3FIR-141. Everything else is just nonconflicting merges, etc.
This also implements the new versioning scheme.