-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TR3FIR-217] Add PKA controller with RSA functionalities #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a first pass, awesome work BTW.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice bits. Pushing partial review so that the ongoing discussions don't get outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sharing another portion of nitpicks. The basis looks very solid though.
c5b4cb1
to
f720fae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly looks fine. I just have a couple questions I'd like to talk through before I approve.
8712ba7
to
1a08752
Compare
Work in progres, there is a problem with exponent. Fix modular exponent Add finished PKA implementation with RSA operations Fix constexpression calculations Replace bytemuck with custom data conversion
[TR3FIR-217] Remove RSA struct from PKA driver [TR3FIR-217] Add padding for PKA RAM writes [TR3FIR-217] Fix modulus padding in PKA mod exp method [TR3FIR-217] Fix modular exp in PKA [TR3FIR-217] Fix Mongtomery param in PKA
1a08752
to
a2090a0
Compare
Squashed all Piotr's and my commits into two separate ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed most of this already, but I re-read through it and it looks fine.
Created PKA driver for RSA operations. Operations include:
Please note that due to the lack of dev board, development has been done on nucleo board, using mainline embassy. Some changes might be needed for this to work with our version of embassy.