Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings #13

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Fix warnings #13

merged 3 commits into from
Feb 2, 2024

Conversation

floitsch
Copy link
Member

@floitsch floitsch commented Jan 18, 2024 •
edited
Loading

No description provided.

@floitsch
Fix deprecation warning in example.
ada4d8a 
The example now needs a version v2.0.0-alpha.218+, but the library itself is still usable with earlier versions.
@floitsch floitsch requested a review from kasperl January 18, 2024 14:02
@floitsch floitsch changed the title Fix deprecation warning in example. Fix warnings Jan 18, 2024
kasperl
kasperl approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@kasperl kasperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@floitsch floitsch merged commit 6881399 into main Feb 2, 2024
1 check passed
@floitsch floitsch deleted the floitsch/fix-warning branch February 2, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperl kasperl kasperl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floitsch @kasperl