Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication support #226

Closed
adongy opened this issue Aug 8, 2024 · 3 comments · Fixed by #231
Closed

Authentication support #226

adongy opened this issue Aug 8, 2024 · 3 comments · Fixed by #231
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@adongy
Copy link

adongy commented Aug 8, 2024

Is your feature request related to a problem? Please describe.
Hello, when using a remote configuration to use Artifactory for example, there is no documented way to use credentials (.netrc or user/password in URL)

Describe the solution you'd like
Document (and implement if needed) how to specify credentials to authenticate to a remote.

Describe alternatives you've considered

Additional context
tofuenv explicitely supports .netrc for that usecase.

Thanks!

@kvendingoldo kvendingoldo added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 8, 2024
@dvaumoron
Copy link
Contributor

http.Get in net/http does not seem to handle .netrc. So this need an implementation step.

@adongy
Copy link
Author

adongy commented Aug 12, 2024

I see. I would add that even .netrc may not be optimal support, as it's hard to put environment variables inside.

For example, https://docs.npmjs.com/using-private-packages-in-a-ci-cd-workflow#create-and-check-in-a-project-specific-npmrc-file is not possible as .netrc does not evaluate environment variables.

If I could choose, I would like it if there was additionnal variables for remote to specify user/password, or allow specifying the user/password in the URL.

Thanks.

@dvaumoron
Copy link
Contributor

https://user:password@host.org should work, however I can add some env var to have a better support.

@dvaumoron dvaumoron self-assigned this Aug 16, 2024
dvaumoron added a commit that referenced this issue Aug 16, 2024
Signed-off-by: Denis Vaumoron <dvaumoron@gmail.com>
dvaumoron added a commit that referenced this issue Aug 16, 2024
Signed-off-by: Denis Vaumoron <dvaumoron@gmail.com>
dvaumoron added a commit that referenced this issue Aug 18, 2024
Signed-off-by: Denis Vaumoron <dvaumoron@gmail.com>
dvaumoron added a commit that referenced this issue Aug 18, 2024
* add basic auth env var #226
* update README for #226

Signed-off-by: Denis Vaumoron <dvaumoron@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants