Add solution for #27 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REDNBLACK
force-pushed
the
suppress_linters_warning
branch
from
50a38fe to
85d7320
Compare
Odomontois
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should never validate macros-generated code.
For example WartRemover with
tethysmacros complains about Any, Var and null, in other cases i've seen asInstanceOf and isInstanceOf casts inside of macro. And there always will be ImplicitParameter and ImplicitConversion warnings, because WartRemover decided so.For this reason i have decided to disable ALL Scalafix, WartRemover and Scapegoat checks on generated implicit definitions with the following @SupressWarnings values:
org.wartremover.warts.All- disables all WartRemover warningsscalafix:all- disables all Scalafix warningsall- disables all Scapegoat warnings