Support estatico newtypes #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Odomontois
force-pushed
the
newtypes
branch
2 times, most recently
from
e8e5a36
to
61b5908
Compare
catostrophe
reviewed
Feb 16, 2021
|
|
||
| val common = List( | ||
| scalaVersion := "2.13.4", | ||
| crossScalaVersions := List("2.12.12", "2.13.4"), | ||
| crossScalaVersions := List("2.12.13", "2.13.4"), |
There was a problem hiding this comment.
and here, please
derevo/.github/workflows/scala.yml
Line 45 in 3dfca42
catostrophe
reviewed
Feb 16, 2021
build.sbt
Outdated
| ), | ||
| libraryDependencies += "io.estatico" %% "newtype" % "0.4.4" % Test, | ||
| libraryDependencies += "org.scalameta" %% "munit" % Version.munit % "test", | ||
| libraryDependencies += "org.scalatest" %% "scalatest" % Version.scalaTest % "test", | ||
| scalacOptions ++= { | ||
| CrossVersion.partialVersion(scalaVersion.value) match { | ||
| case Some((2, y)) if y == 11 => Seq("-Xexperimental") |
FunFunFine
reviewed
Feb 16, 2021
FunFunFine
reviewed
Feb 16, 2021
| @@ -0,0 +1,10 @@ | |||
| package derevo | |||
|
|
|||
| //* utilitary holder for the newtype instance derivation */ | |||
There was a problem hiding this comment.
Suggested change
| //* utilitary holder for the newtype instance derivation */ | |
| /* Utilitary holder for the newtype instance derivation */ |
|
That was quick! 🚀 |
|
@Odomontois is there a SNAPSHOT I can try? I checked the CI actions, it seems there's no job publishing them automatically, no? |
|
No, we haven't configured any snapshot/early yet |
|
Ah no problems, no rush. Ping me when there's a new release / snapshot so I can keep up with my promise 😄 |
|
@gvolpe we have released to sonatype https://oss.sonatype.org/content/groups/public/tf/tofu/ |
|
Awesome, thanks for letting me know! 👍 |
|
Bumped into this issue 😿 #220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #56
Note that derevo-core dependency does not brings the estatico dependency.
Moreover, the mechanism could be easily extended for the "marks" of the other "newtype" libraries