feat(edgeless): move selection or shapes with spacebar while dragging like other graphic tools #6219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
golok727
changed the title
golok727
force-pushed
the
space-move
branch
2 times, most recently
from
bc9babf to
f0b8fc7
Compare
|
This feature looks great to me. But the current edgeless tools API is a little cumbersome and we are likely to simplify this part soon. So a few tests would be better. |
|
@doouding I have added some tests PTAL. |
|
Hey, thank you for the continuous follow-up. I also left some comments about the code. You can take a look. |
doouding
requested changes
Feb 20, 2024
packages/blocks/src/page-block/edgeless/edgeless-page-service.ts
Outdated
Show resolved
Hide resolved
packages/blocks/src/page-block/edgeless/controllers/tools/shape-tool.ts
Outdated
Show resolved
Hide resolved
doouding
approved these changes
Feb 21, 2024
This was referenced Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Implemented the ability for users to adjust selection or shape positions during creation by holding the spacebar, providing a more intuitive experience reminiscent of tools like Figma.
Extras
Demo
Feature.Preview.mp4