-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(edgeless): edgeless related api #5972
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
doouding
changed the title
refactor(edgeless): redesign edgeless related api
refactor(edgeless): edgeless related api
Jan 12, 2024
doodlewind
reviewed
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: remove redundancy in onYBlockUpdated
Saul-Mirone
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surface model & element model
observe
decorator to allow observe the yjs type property. E.g., thechildren
property of group element.convert
decorator to allow convert the new value before assigning to or updating the model property. It will gradually replace the existing functionpropsToY
.connector
is dynamically generated based on itssource
andtarget
properties in real-time, and it is not stored persistently in Yjs. To ensure the surface model is plug-and-play, the logic for generating the connector path is integrated through middleware.externalXYWH
for element model, to store the rect dimensions of content associated with the element, such as the bounding rect of a group's title. This attribute is updated by the renderer during the rendering process. Once this data is stored, the relevant content becomes interactive and is also decoupled from the renderer.Edgeless API & canvas renderer
EdgelessBlockModel
andElementModel
. Both of them can be used with theinstanceof
operator.elementUpdated
,elementAdded
, andelementRemoved
. Use the slot of the model instead.