Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multilanguage Support - Sonarr API v3 Parameter #52

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

Seriox
Copy link
Contributor

@Seriox Seriox commented Aug 16, 2022

For #51

Basically I just copied/pasted everything regarding Quality Profile as it is very similar to the language profile. A GET Request for language profiles only works with Sonarr API v3.
Tested with 1,2 and 3 languages. (en_us.yml) Searcharr let's me select between the languages if more than one language is specified in settings.py. If only one language is set, than Searcharr just uses that one.

Feel free to close this PR if not needed or you want to do it differently.

@toddrob99 toddrob99 self-assigned this Aug 16, 2022
@toddrob99 toddrob99 changed the base branch from main to beta October 13, 2022 18:05
@toddrob99 toddrob99 merged commit aa659c1 into toddrob99:beta Oct 13, 2022
@toddrob99 toddrob99 mentioned this pull request Oct 13, 2022
Merged
@toddrob99
Copy link
Owner

toddrob99 commented Dec 15, 2022

@Seriox, it appears Sonarr is deprecating language profiles and adding language support to custom formats instead. After upgrading to Sonarr v4 in my test instance, the response to the languageprofile API endpoint has changed to this (I had multiple languages enabled in the language profile before, and it was not named "Deprecated"):

[
  {
    "name": "Deprecated",
    "upgradeAllowed": true,
    "cutoff": {
      "id": 1,
      "name": "English"
    },
    "languages": [
      {
        "language": {
          "id": 1,
          "name": "English"
        },
        "allowed": true
      }
    ],
    "id": 1
  }
]

As a result, I am going to remove language profile support from Searcharr v3.

@Seriox
Copy link
Contributor Author

Seriox commented Dec 15, 2022

Alright, I think it's similar to Radarr then. I would say that this solution (in v4) is a lot better than having multiple language profiles besides the quality Profiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants