remove all uses of lang_items unstable feature #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair23
approved these changes
Jun 17, 2020
ppannuto
approved these changes
Jun 17, 2020
There was a problem hiding this comment.
bors r+
This is great. If I understand correctly, if folks try to use a different panic mechanism, they'll get a missing symbol error for eh_personality now, which frankly is probably a good thing, as there are likely other expectations not met by our old empty function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request removes all uses of the lang_items unstable feature, to get us closer to building Tock on stable rust.
Originally, lang_items was required to declare the global panic handler, but that was changed by rust-lang/rust#51366 . After that, we seem to have just kept it around for declaring a dummy
eh_personality()implementation, which I understand is not needed if you build with panic=abort (which we do for both release and debug builds). see: https://os.phil-opp.com/freestanding-rust-binary/Testing Strategy
This pull request was tested by compiling, running a normal app on Imix, and by panicing intentionally and observing the output looks normal.
TODO or Help Wanted
Confirmation that I am correct in my understanding that we do not need eh_personality because we always use panic=abort.
Documentation Updated
Formatting
make prepush.