Allow filtering of data when some keyed columns contain null #2
Conversation
| if (value.toLowerCase().indexOf(this.filterText.toLowerCase()) > -1) { | ||
| filteredData.push(next); | ||
| break; | ||
| if( next[key]){ |
There was a problem hiding this comment.
If the property in question has a value of 0, it will evaluate to false.
We need to check if next[key] != null && next[key] != undefined
There was a problem hiding this comment.
great point, although next[key] != null also checks for undefined due to coercion. I'll fix this in the pull request.
|
Thank you for sending the pull request, I added a small note. |
|
I reverted the whitespace change on the build (sorry!). Great catch on |
|
I have merged your pull request. Thank you for the fix :) I'm glad you like the table, this is my very first open source contribution, please don't hesitate to send any comments or suggestions. |
If you have a collection where some of the objects have a property that resolves to
null, and you set the filter-keys to contain that property, thedoFiltermethod would stop with an error trying to calltoString()on the null value.