Fix(optimizer): column qualify not applying in an order by inside within group when it also the alias

[ran-lakeway]

example test code

query = """
    SELECT group_name, GROUP_CONCAT(name, ', ') WITHIN GROUP (ORDER BY sub_group_name NULLS LAST) AS sub_group_name
    FROM department 
    GROUP BY group_name
"""

parsed_query = parse_one(query)
qualified_query = qualify(parsed_query, schema={"department": {"group_name": "string", "sub_group_name": "string", "name": "string"}})

print(qualified_query.sql(pretty=True))

current output

SELECT
  "department"."group_name" AS "group_name",
  GROUP_CONCAT("department"."name", ', ') WITHIN GROUP (ORDER BY
    "sub_group_name" NULLS LAST) AS "sub_group_name"
FROM "department" AS "department"
GROUP BY
  "department"."group_name"

after fix

SELECT
  "department"."group_name" AS "group_name",
  GROUP_CONCAT("department"."name", ', ') WITHIN GROUP (ORDER BY
    "department"."sub_group_name" NULLS LAST) AS "sub_group_name"
FROM "department" AS "department"
GROUP BY
  "department"."group_name"

[georgesittas]

Hi @ran-lakeway, can you please add test(s) for this? Thanks for the contribution!

[georgesittas]

I can add a test for this.