Skip to content

Commit

Permalink
spi: spi-qcom-qspi: Fix remaining driver nits
Browse files Browse the repository at this point in the history
Address remaining comments from original driver patch series

* Move RD_FIFO_CFG to be ordered corretly
* Expand spinlock comment

Signed-off-by: Ryan Case <ryandcase@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Ryan Case authored and broonie committed Nov 22, 2018
1 parent 1fc12b0 commit 478652f
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/spi/spi-qcom-qspi.c
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@
#define PIO_DATAOUT_1B 0x0020
#define PIO_DATAOUT_4B 0x0024

#define RD_FIFO_CFG 0x0028
#define CONTINUOUS_MODE BIT(0)

#define RD_FIFO_STATUS 0x002c
#define FIFO_EMPTY BIT(11)
#define WR_CNTS_MSK 0x7f0
Expand All @@ -99,9 +102,6 @@
#define RDY_16BYTE BIT(1)
#define FIFO_RDY BIT(0)

#define RD_FIFO_CFG 0x0028
#define CONTINUOUS_MODE BIT(0)

#define RD_FIFO_RESET 0x0030
#define RESET_FIFO BIT(0)

Expand Down Expand Up @@ -139,7 +139,7 @@ struct qcom_qspi {
struct device *dev;
struct clk_bulk_data clks[QSPI_NUM_CLKS];
struct qspi_xfer xfer;
/* Lock to protect data accessed by IRQs */
/* Lock to protect xfer and IRQ accessed registers */
spinlock_t lock;
};

Expand Down

0 comments on commit 478652f

Please sign in to comment.