Add support for angular 9 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [acorn](https://github.com/acornjs/acorn) from 6.4.0 to 6.4.1. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@6.4.0...6.4.1) Signed-off-by: dependabot[bot] <support@github.com>
…orn-6.4.1 Bump acorn from 6.4.0 to 6.4.1
Bumps [acorn](https://github.com/acornjs/acorn) from 6.4.0 to 6.4.1. **This update includes a security fix.** - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@6.4.0...6.4.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [protractor](https://github.com/angular/protractor) from 5.4.2 to 5.4.3. - [Release notes](https://github.com/angular/protractor/releases) - [Changelog](https://github.com/angular/protractor/blob/master/CHANGELOG.md) - [Commits](angular/protractor@5.4.2...5.4.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [wait-on](https://github.com/jeffbski/wait-on) from 3.3.0 to 4.0.1. - [Release notes](https://github.com/jeffbski/wait-on/releases) - [Commits](jeffbski/wait-on@v3.3.0...v4.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [@angular-devkit/build-ng-packagr](https://github.com/angular/angular-cli) from 0.803.21 to 0.803.25. - [Release notes](https://github.com/angular/angular-cli/releases) - [Commits](https://github.com/angular/angular-cli/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 8.9.5 to 13.9.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…orn-6.4.1 [Security] Bump acorn from 6.4.0 to 6.4.1
…otractor-5.4.3 Bump protractor from 5.4.2 to 5.4.3
…gular-devkit/build-ng-packagr-0.803.25 Bump @angular-devkit/build-ng-packagr from 0.803.21 to 0.803.25
…it-on-4.0.1 Bump wait-on from 3.3.0 to 4.0.1
Bumps [tslib](https://github.com/Microsoft/tslib) from 1.10.0 to 1.11.1. - [Release notes](https://github.com/Microsoft/tslib/releases) - [Commits](microsoft/tslib@1.10.0...1.11.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [jasmine-core](https://github.com/jasmine/jasmine) from 3.4.0 to 3.5.0. - [Release notes](https://github.com/jasmine/jasmine/releases) - [Changelog](https://github.com/jasmine/jasmine/blob/master/RELEASE.md) - [Commits](jasmine/jasmine@v3.4.0...v3.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [karma-jasmine](https://github.com/karma-runner/karma-jasmine) from 2.0.1 to 3.1.1. - [Release notes](https://github.com/karma-runner/karma-jasmine/releases) - [Changelog](https://github.com/karma-runner/karma-jasmine/blob/master/CHANGELOG.md) - [Commits](karma-runner/karma-jasmine@v2.0.1...v3.1.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…pes/node-13.9.1 Bump @types/node from 8.9.5 to 13.9.1
…asmine-core-3.5.0 Bump jasmine-core from 3.4.0 to 3.5.0
…lib-1.11.1 Bump tslib from 1.10.0 to 1.11.1
…arma-jasmine-3.1.1 Bump karma-jasmine from 2.0.1 to 3.1.1
|
@tnicola please merge this PR ... the current version is preventing anyone from upgrading to angular 10. Thanks! |
tnicola
reviewed
Jul 1, 2020
| @@ -52,7 +57,7 @@ | |||
| "main": "projects/demo/src/main.ts", | |||
| "polyfills": "projects/demo/src/polyfills.ts", | |||
| "tsConfig": "projects/demo/tsconfig.app.json", | |||
| "aot": false, | |||
| "aot": true, | |||
There was a problem hiding this comment.
@alexsukhodolsky I would be happy to merge it but unfortunately the unit test compilation is failing. Probably due to this change. @lehoffma Can you check this please?
There was a problem hiding this comment.
I tried that, but it didn't change the test results for me. The broken unit tests were mostly due to the updated libraries like rxjs I think. I rebased and pushed a fix for the tests, let me know if there's anything else I can do.
|
@lehoffma PR merged, thanks!A new version of the package has been released: ngx-joyride@2.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I let the
ng update @angular/core @angular/climigration run on the whole project, which means the demo app now uses Angular 9 too.