Fix: Update staggered start delay thread.js #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are facing random issues (roughly 2/10 runs) where the second thread's command is triggered but doesn't execute any tests.
hatseh
changed the title
tnicola
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using Cypress-parallel to run our tests in 6 parallel threads inside a docker image cypress/included 12.14.
But we are facing a random issues (roughly 2/10 runs) where the second thread's command is triggered but doesn't execute any tests, meaning cypress is not even opened.
This seems to be similar to issue #122, but the difference is that the run is not even started.
Delaying the staggered threads a bit more seems to solve the issue.