Fix the logic #135
Merged
Fix the logic #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hiroyone any idea when this will get reviewed/merged? I'm facing the issue this appears to fix. |
|
Let's ask the creator. @tnicola |
|
Thanks for your contribution @hiroyone !It's now merged and published in 0.10.0 |
| fs.readdir(resultsPath, (err, files) => { | ||
| if (err) console.log(err); | ||
| for (const file of files) { | ||
| fs.unlink(path.join('path here', file), err => { if (err) console.log(err); }); |
There was a problem hiding this comment.
Hi @hiroyone - should the string "path here" have been present here? I'm seeing it surface when I run the tool.
There was a problem hiding this comment.
Oh it should be a mistake.
Instead of 'path here', resultsPath seems correct, isn't it?
There was a problem hiding this comment.
Thank you @hiroyone for updating it so quickly! I've tested and the error is gone.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #56
The cleanResultsPath method should have an empty folder, but the current logic was removing the directory.
The fixed logic cleans up all files in the directory but keep the directory itself.