Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CourseInfo Using Deprecated Dynamic Proprties #485

Closed
martygilbert opened this issue Jun 28, 2024 · 0 comments · Fixed by #487
Closed

CourseInfo Using Deprecated Dynamic Proprties #485

martygilbert opened this issue Jun 28, 2024 · 0 comments · Fixed by #487

Comments

@martygilbert
Copy link
Contributor

  • moosh version: bf8a534
  • moodle version: 4.3.5+
    • database: MariaDB 11.4.2
  • php version: 8.2.19
  • operating system: GNU/Linux

Actual behaviour

when calling moosh course-info XXXX, deprecation warnings about using dynamic properties fill the first several lines.

image

Expected behaviour

Should not have any deprecation warnings, and the properties should be declared properly.

Steps to reproduce

moosh course-info XXXX
martygilbert added a commit to martygilbert/moosh that referenced this issue Jun 28, 2024
@martygilbert
MOOSH485 - Fix Dynamic Properties in CourseInfo.php
9e9f6f0 
This fixes tmuras#485.

The properties $enrolledtotal, $logsnumber, and $data were not declared.
This fix declares them as private class properties, removing the
warning.
This was referenced Jun 28, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@martygilbert