Updating type script date format

[jacob-kinzer]

Updating typescript for the graphs to pass back the date in the correct formatting using iso8601 which should guarantee an 2 digit format for month and day.

In reference to #117

Sidenote: I am by no means an expert in JS/TS so any feedback is welcome.

Aha! Link: https://t-mobile1t-mobile.aha.io/features/PM-390

[adiagrwl94]

Reopening as this is in master.

[adiagrwl94]

The date in ISOString is of YYYYMMDD format and instead of making date by getMonth() + 1, this would take care of the date format as well as timezone differences to UTC. Approving the PR. @jacob-kinzer Thank you for your contribution! We can close issue 117 with this.

[adiagrwl94]

@jacob-kinzer Feedback: The javascript prevDate.setMonth(prevDate.getMonth() - 1); will take care even if month is January. You wouldn't need to explicitly handle it by setting one month back as December and of previous year. This is handled by the setMonth itself!

[jacob-kinzer]

@jacob-kinzer Feedback: The javascript prevDate.setMonth(prevDate.getMonth() - 1); will take care even if month is January. You wouldn't need to explicitly handle it by setting one month back as December and of previous year. This is handled by the setMonth itself!

Sorry do you mean like

pacbot/webapp/src/app/pacman-features/secondary-components/certificate-assets-trend/certificate-assets-trend.component.ts

Line 118 in 98968b9

today.setMonth(today.getMonth() - 1);

? During my testing it seemed like the backend API was expecting the date to be a month back, otherwise if i did not set it a month back the graphs were only show today - today, if that makes sense. Let me know if i misunderstood what you were referencing though.

[adiagrwl94]

@jacob-kinzer What I mean to say is in:

if (today.getMonth() === 0) { // No need to handle this
today.setFullYear(today.getFullYear() - 1); // not required
today.setMonth(11); // not required
fromDay = today.toISOString().substring(0, 10);
}

The else { today.setMonth(today.getMonth() - 1); fromDay = today.toISOString().substring(0, 10); } will take care of getMonth() == 0 (January) too. The JS takes January minus one month as December of Previous year in setDate()!

[adiagrwl94]

@jacob-kinzer It would be great if you could contribute further to this!

[jacob-kinzer]

Sorry i wasnt able to get back to you faster work has been busy. I am not sure if this PR is needed anymore. It looks like there is a commit in the 1.2 branch that should handle this use case:

3ca755c

If this PR is still needed i can update it otherwise i think it can be closed.

[adiagrwl94]

@jacob-kinzer We would still be looking forward for this PR and requested change to be made as this is to master branch. Please do remove the redundant separate handling of getMonth() === 0 as this is not required as an if-else loop. Thanks.

Example:
const dateToday = new Date('2019-01-03'); // January
let earlierDate = new Date(dateToday)
earlierDate.setMonth(dateToday.getMonth() - 1); // One month before January
earlierDate = earlierDate.toISOString().substring(0, 10);
console.log(earlierDate); // December of previous year (2018-12-03)

[CLAassistant]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 7 committers have signed the CLA.

✅ kaykumar
✅ johnakash
✅ sajeer-nooh
❌ root
❌ codingalyona
❌ jacob-kinzer
❌ sukesh-ss

---

root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}