Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup PR for golang runtime support #430

Merged
merged 2 commits into from
Dec 20, 2018
Merged

Followup PR for golang runtime support #430

merged 2 commits into from
Dec 20, 2018

Conversation

Johnbush
Copy link
Contributor

Description of Change

  • Removed extra RUN command

  • Fixed Setting path for golang on Docker Images

devsatishm
devsatishm approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@devsatishm devsatishm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rajeevr2715
rajeevr2715 approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@rajeevr2715 rajeevr2715 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@devsatishm devsatishm merged commit 98e7145 into tmobile:develop Dec 20, 2018
@Johnbush Johnbush mentioned this pull request Dec 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsatishm devsatishm devsatishm approved these changes

@rajeevr2715 rajeevr2715 rajeevr2715 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Johnbush @devsatishm @rajeevr2715