-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unneeded delay in momentary layer switch #201
Comments
Hey, I noticed the delay as well some time ago (My LEDs indicate the active layer, so the delay was very apparent), and today it hit me what was causing the delay. It's the tapping delay, as you said, so the issue isn't with the tapping mechanism, but the fact that it's being used wrongly. :p The fix is rather simple, change this define (in common/action_code.h):
into:
|
Nice. And this gaves me a clue of where the problem root was. Fixed at 1f4a22e. |
caca2c0 Add mouse support to ADB 5b0835a Merge commit '1fe4406f374291ab2e86e95a97341fd9c475fcb8' f2f7556 Remove unneeded tap delays #201 8124195 Fix URL of HID Usage Tables pdf 0bb4679 Fix typo of doc/keycode.txt b24fa1a Fix handling of consumer usage #199 6ae1a3d Improve anti-ghosting behavior for fast typing a4c9763 Fix dfu-programmer parameters b62b3f2 Move ring_buffer.h file 6ec424f Fix debug print 502fb0c Fix ibm4704 protocol with using interrupt git-subtree-dir: tmk_core git-subtree-split: caca2c0
Further improvements to mpiechotka keyboard
Press Fn(Layer switch momentary) then a key on the layer immediately, you will see delay before appearing the key on terminal.
EDIT: The delay is obvious when keeping the key preessed to get key repeating. For example, users keep 'Fn + ;' pressed down on HHKB keymap to get left arrow repeating. Meanwhile, if the key is released immediately it registered when released and the delay is not obvious.
The delay seems to be related to
TAPPING_TERM
.Probably tapping code has a bug.
https://geekhack.org/index.php?topic=56494.msg1715297#msg1715297
The text was updated successfully, but these errors were encountered: