Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unneeded delay in momentary layer switch #201

Closed
tmk opened this issue Apr 13, 2015 · 2 comments
Closed

unneeded delay in momentary layer switch #201

tmk opened this issue Apr 13, 2015 · 2 comments

Comments

@tmk
Copy link
Owner

tmk commented Apr 13, 2015

Press Fn(Layer switch momentary) then a key on the layer immediately, you will see delay before appearing the key on terminal.

EDIT: The delay is obvious when keeping the key preessed to get key repeating. For example, users keep 'Fn + ;' pressed down on HHKB keymap to get left arrow repeating. Meanwhile, if the key is released immediately it registered when released and the delay is not obvious.

The delay seems to be related to TAPPING_TERM.

Probably tapping code has a bug.

https://geekhack.org/index.php?topic=56494.msg1715297#msg1715297

@boblehest
Copy link

Hey, I noticed the delay as well some time ago (My LEDs indicate the active layer, so the delay was very apparent), and today it hit me what was causing the delay. It's the tapping delay, as you said, so the issue isn't with the tapping mechanism, but the fact that it's being used wrongly. :p

The fix is rather simple, change this define (in common/action_code.h):

#define ACTION_LAYER_MOMENTARY(layer)    ACTION_LAYER_ON_OFF(layer)

into:

#define ACTION_LAYER_MOMENTARY(layer)    ACTION_LAYER_INVERT(layer, ON_BOTH)

tmk added a commit that referenced this issue Apr 23, 2015
@tmk
Copy link
Owner Author

tmk commented Apr 23, 2015

Nice.

And this gaves me a clue of where the problem root was.

Fixed at 1f4a22e.

@tmk tmk closed this as completed Apr 23, 2015
tmk added a commit that referenced this issue Apr 28, 2015
tmk added a commit that referenced this issue Apr 28, 2015
caca2c0 Add mouse support to ADB
5b0835a Merge commit '1fe4406f374291ab2e86e95a97341fd9c475fcb8'
f2f7556 Remove unneeded tap delays #201
8124195 Fix URL of HID Usage Tables pdf
0bb4679 Fix typo of doc/keycode.txt
b24fa1a Fix handling of consumer usage #199
6ae1a3d Improve anti-ghosting behavior for fast typing
a4c9763 Fix dfu-programmer parameters
b62b3f2 Move ring_buffer.h file
6ec424f Fix debug print
502fb0c Fix ibm4704 protocol with using interrupt

git-subtree-dir: tmk_core
git-subtree-split: caca2c0
Lokaltog pushed a commit to Lokaltog/tmk_keyboard that referenced this issue Jun 17, 2015
yoyoerx pushed a commit to yoyoerx/qmk_keyboard that referenced this issue Mar 21, 2016
Further improvements to mpiechotka keyboard
kairyu pushed a commit to kairyu/tmk_keyboard that referenced this issue Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants