Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for console.AskAsync, console.ConfirmAsync #1

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

FrankRay78
Copy link

  • Unit tests for console.AskAsync, console.ConfirmAsync
  • Reordering of some code for better self-documentation

@FrankRay78
Copy link
Author

Hello @tmds, I had a few spare cycles today and knocked up the attached unit test coverage for your spectreconsole#1194

Could you peer review this PR, and either:

  1. Merge, push to the PR branch
  2. Make changes, then 1.
  3. Tell me if you don't agree/don't like this, and we can have a discussion

We should take the mindset of peers collaborating, not you trying to appease me. So speak openly, and we'll get to a point of both being in agreement the PR is good to merge.

I hope that makes sense.

@tmds
Copy link
Owner

tmds commented Nov 26, 2024

Thanks for helping me complete the PR @FrankRay78!

@tmds tmds merged commit 619a69c into tmds:async_prompts Nov 26, 2024
@FrankRay78 FrankRay78 deleted the async_prompts branch November 26, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants