Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore it and describe nodes with evaluated expressions #362

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jinbijin
Copy link

Description

Corrects rule state in branch mode if a call to describe or it is encountered with an evaluated expression as first argument. Fixes #164 .

How has this been tested?

Added mocha tests to no-suite-dupes and no-spec-dupes, and confirmed that they failed before the change in the no-dupes helper.

Types of changes

  • Test change (non-breaking change which adds additional test scenarios)
  • Refactor change (non-breaking change updates coding styles)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have ran npm run test and everything passes
  • My code follows the code style of this project
  • I have updated the documentation where necessary
  • I have read the CONTRIBUTING document
  • I have added tests to cover my changes
  • All new and existing tests pass

…evaluated expressions

Corrects rule state in branch mode if a call to `describe` or `it` is encountered with an evaluated expression as first argument. Fixes tlvince#164.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-spec-dupes branch scoping fails when describe blocks are defined with template literals as the name
1 participant